Martin Betak has submitted this change and it was merged. Change subject: webadmin, core: random renamed to urandom in VM dialog ...................................................................... webadmin, core: random renamed to urandom in VM dialog Up to version 4.0 there were two random generator sources: /dev/random and /dev/hwrng in the engine. Since engine 4.1 /dev/random is going to be replaced by /dev/urandom. Set of random generators available for VM depends purely on set of generators currently selected on Cluster, not on effective VM compatibility level. This patch * adds new VmRngDevice.Source#URANDOM enum item. * introduces conditional labels VM dialogs for urandom/random based on selected cluster version. * value of urandom/random radiobutton in VM dialog depends on currently selected cluster; is 'urandom' for non-cluster entities (Blank template and instance types). Change-Id: I6c17dc780310020567e5f8b40938765f4dc9a5a2 Bug-Url: https://bugzilla.redhat.com/1374227 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java 9 files changed, 86 insertions(+), 29 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c17dc780310020567e5f8b40938765f4dc9a5a2 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>