Change in ovirt-engine[master]: webadmin: ListModelObjectCellTable ArrayList ctor

From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: ListModelObjectCellTable ArrayList ctor ...................................................................... webadmin: ListModelObjectCellTable ArrayList ctor This patch creates an ArrayList from the getSelectedSet() by using the overloaded consturctor instead of looping over getSelectedSet() and calling List#add for each element. At worst, this syntax is just cleaner and easier to understand. At best, it may offer a slightly improved performance, as the ArrayList has prior knowledge of the number of elements being added to it, and can thus avoid resizes. Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelObjectCellTable.java 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ab0b97006e95007e8495a7c017b563bcc148de8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review