Arik Hadas has submitted this change and it was merged. Change subject: core: monitoring vm devices using the domain xml ...................................................................... core: monitoring vm devices using the domain xml The monitoring of vm devices can now be done according to libvirt's domain xml rather than the dictionary we used to get from VDSM. However, in order to minimize the changes in vm devices monitoring, we convert the devices in the domain xml into VDSM-like maps that contain the relevant data, but this is done on the engine side. Note that the DomainXML config value still defaults to false, so we still call FullList by default (this is going to be changed separately, once the monitoring of host devices is added). Change-Id: I04e03e1137567ff8a14c2b07b1e8f02d1a832b8c Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DumpXmlsVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java 4 files changed, 540 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70018 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04e03e1137567ff8a14c2b07b1e8f02d1a832b8c Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt; Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com&gt; Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com&gt; Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;