Arik Hadas has submitted this change and it was merged. Change subject: core: manage vm-jobs in-memory ...................................................................... core: manage vm-jobs in-memory Previously the process was: MergeCommand -> persist job into the database Monitoring -> on each cycle read jobs from the database and compare them with the jobs reported by vdsm The patch suggests another way: MergeCommand -> pass the job to the monitoring that persists it into the database and store it in-memory Monitoring -> compare the reported jobs with the the jobs that are stored in-memory On startup, the monitoring retrieve all the existing job in the database. This way, we reduce the number of reads from the database. Change-Id: Id8a9e935f49f458388c089398b110a8854c197e5 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmJobDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoringTest.java M packaging/dbscripts/vm_jobs_sp.sql 7 files changed, 102 insertions(+), 67 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8a9e935f49f458388c089398b110a8854c197e5 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>