Change in ovirt-engine[master]: Fixing a bug preventing daemons from regaining DB connectivi...

Yair Zaslavsky has submitted this change and it was merged. Change subject: Fixing a bug preventing daemons from regaining DB connectivity ...................................................................... Fixing a bug preventing daemons from regaining DB connectivity If db connectivity is down, closeConnection in checkConnection will set connection null. From that point on, on each call to checkConnectivity a NPE will be thrown. Fix: If connection is null attempt to open it, this way: 1.) if db goes back up we will regain connectivity. 2.) if db does not come back up we will have a proper sqlException in the log thrown from openConnection, and not a NPE. Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=973534 Signed-off-by: Mooli Tayer <mtayer@redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8dc7eb95e055e793f51155cd4024ebf5ce1914a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: mooli tayer <mtayer@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server
participants (1)
-
yzaslavs@redhat.com