Tal Nisan has submitted this change and it was merged. Change subject: core: Calculate disk alias on add disk prior to setting the job message ...................................................................... core: Calculate disk alias on add disk prior to setting the job message The disk alias to be created is calculated during the execution phase so if the user hasn't specified one, during the job creation the alias will not appear in the task description, the setting of the alias (whether it's default or the one the user supplied) is now done in the job message calculation phase Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Signed-off-by: Tal Nisan <tnisan@redhat.com> Bug-Url: https://bugzilla.redhat.com/1143967 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idee55da516bca986993e973dffc9058187e12a34 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server