From Tal Nisan <tnisan@redhat.com>:

Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor of setting disk attributes. ...................................................................... core: Refactor of setting disk attributes. Engine updates the new disk image with updated size and actual size attributes based on the downloaded image retrieved from Glance. The engine reads the image using inputstream and therefore makes it hard to maintain for extra fields to update. The proposed patch refactors the update of the disk image fields, to be done inside the parsing method, making diskImage a parameter in the method signature. Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Bug-Url: https://bugzilla.redhat.com/1456432 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 1 file changed, 20 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>