Change in ovirt-engine[master]: restapi: Test anonymous extensions

From Tal Nisan <tnisan@redhat.com>:
Tal Nisan has submitted this change and it was merged. Change subject: restapi: Test anonymous extensions ...................................................................... restapi: Test anonymous extensions This patch replaces anonymous extensions that call setter methods with explicit creations of new instances and calls to those setters in separate statements. While the current code is not technically wrong (just arguably awkward to read and maintain), it will fail the OneStatementPerLine check in newer Checkstyle versions. Change-Id: Ie7ce0e6ff7a8fe0afbfc475c56f809c15c7aa6a3 Related-To: https://bugzilla.redhat.com/1433408 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExternalVmImportsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 3 files changed, 11 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/74428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7ce0e6ff7a8fe0afbfc475c56f809c15c7aa6a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
Code Review