Tal Nisan has submitted this change and it was merged. Change subject: core: Improve calculation of disk actual/committed size ...................................................................... core: Improve calculation of disk actual/committed size The various views containing the disk actual and committed sizes on storage domains was done by functions which performed aggregate queries, per storage domain. By converting them to joins, the calculation can be done in parallel on all the domains, like databases are supposed to be used. This patch performs the following: 1. Creates the storage_domains_image_sizes view to encapsulate the logic previously performed by the fn_get_disk_commited_value_by_storage and fn_get_actual_images_size_by_storage stored functions. 2. Remove the aforementioned functions. 3. Add some assertions to the DAO test to ensure the functionality is preserved. Change-Id: I1c76870153d55c4a4259ecaf6e9b96297f16aa72 Bug-Url: https://bugzilla.redhat.com/1341661 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M packaging/dbscripts/create_functions.sql M packaging/dbscripts/create_views.sql 3 files changed, 61 insertions(+), 67 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/57684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c76870153d55c4a4259ecaf6e9b96297f16aa72 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;