Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Added generic DB validations before the upgrade ...................................................................... packaging: Added generic DB validations before the upgrade * This patch adds a simple validatedb.sh script that will run required validation scripts. * When a new validation script is added, it should be added to the validatedb runner script as well. * During the upgrade, this script is executed and handles the validations control to corresponding scripts. * If user decides not to clear DB issues or there's any other error, the exception is raised. * Patch also introduces some code cleanups Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98 Bug-Url: https://bugzilla.redhat.com/893459 Signed-off-by: Alex Lourie <alourie@redhat.com> --- M Makefile M backend/manager/tools/dbutils/fkvalidator.sh M backend/manager/tools/dbutils/fkvalidator_sp.sql A backend/manager/tools/dbutils/validatedb.sh M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 200 insertions(+), 25 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie@redhat.com> Gerrit-Reviewer: Alex Lourie <alourie@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com>