Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Move Network QoS logic to common ground ...................................................................... webadmin: Move Network QoS logic to common ground Made the following changes to allow Host Network QoS access to logic implemented for VM Network QoS: * Created an AsyncDataProvider method to conveniently retrieve NetworkQoS entities for a given DC, which also adds the empty QoS (unlimited) to the top of the list. * Moved the empty network QoS definition from VnicProfileModel to NetworkQoSModel. It's the best location I found for it in the frontend, otherwise it belongs in the common project (but the backend doesn't use it). * Moved the QoS selection logic to Linq. Change-Id: Ib32cfe2392e86431323176fa9ef3e0aa00dbb841 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQoSModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 4 files changed, 39 insertions(+), 27 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib32cfe2392e86431323176fa9ef3e0aa00dbb841 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server