Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: use common pg_cmd ...................................................................... packaging: engine-backup: use common pg_cmd No need to copy pg_cmd around. 'local' variables defined by a bash (and ash/dash/posh) function are inherrited by other functions called from it. Change-Id: I745db3155f679a6cd6f49763d3f9df4e08031156 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com&gt; --- M packaging/bin/engine-backup.sh 1 file changed, 18 insertions(+), 39 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/40237 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I745db3155f679a6cd6f49763d3f9df4e08031156 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server