Maor Lipchuk has submitted this change and it was merged. Change subject: core: Filter GetAllAttachableDisksByPoolId ...................................................................... core: Filter GetAllAttachableDisksByPoolId Added permission filtering to GetAllAttachableDisksByPoolId, instead of the stub implementation that was present there. This patch includes the filtering code, a test for it, and some testing data in fixtures.xml. Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/dbscripts/all_disks_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 37 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04f319a036952567f1e7f9a2761ec98753052bae Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>