Martin Betak has submitted this change and it was merged. Change subject: core: Imports of spice-html5 fixed ...................................................................... core: Imports of spice-html5 fixed Previously not all files of spice-html5 library were included (using <script> tag) and it seemed to work ok up to v0.1.6. In v0.1.7 it started to throw "ReferenceError: GAP_DETECTION_THRESHOLD is not defined". This patch imports all yet not imported *.js files from spice-html5 distribution and thus eliminating the error. Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/services/src/main/webapp/spicehtml5-main.jsp 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idadaeffd4c8ce97d4a54de97b65709e9f60cc145 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>