Martin Peřina has submitted this change and it was merged. Change subject: core: convert memory volumes only on active snapshots to disks properly ...................................................................... core: convert memory volumes only on active snapshots to disks properly We have no vm_configuration on snapshots of type ACTIVE, thus we need special treatment for this case. The solution is: - If the same memory resides on both ACTIVE and other than ACTIVE snapshots, process one of the snapshots that is not ACTIVE. - If the memory resides only on ACTIVE snapshot, compute its size according to the values in vm_static rather than in vm_configuration. Change-Id: I715082f267b5eaa325cc2bb8988b25ac89e3b043 Bug-Url: https://bugzilla.redhat.com/1382746 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 33 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715082f267b5eaa325cc2bb8988b25ac89e3b043 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>