Allon Mureinik has submitted this change and it was merged. Change subject: engine: Iterable @DataPoints ...................................................................... engine: Iterable @DataPoints With the upgrade to JUnit 4.12, Iterables can be used as @DataPoints (see PR #658). This patch removes the boiler plate code needed to convert Iterabls to arrays, in order to make the code cleaner and easier to read. Note that where using an array was simpler (e.g., SomeEnum#values() was used a @DataPoints), the method was left untouched. Change-Id: I8f2fc6a32ab64a28db6dab9da080e1b47817a1f6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt; --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/DestroyImageCheckCommandTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtilTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AbstractConstantsWithLookupTestCase.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/AppErrorsTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/VdsmErrorsTest.java 6 files changed, 16 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f2fc6a32ab64a28db6dab9da080e1b47817a1f6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;