Allon Mureinik has submitted this change and it was merged. Change subject: core: TestCommon @BeforeClass and @AfterClass ...................................................................... core: TestCommon @BeforeClass and @AfterClass All the tests in the this suite start with calling TestCommon.initialize() and they all end with calling TestCommon.terminate(). Instead of repeating these calls, a much cleaner approach would be to simply annotate them as such, have all the tests extend TestCommon, and allow JUnit to do all the heavy lifting. Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java 5 files changed, 8 insertions(+), 44 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia362d885ddb184d35e1d3851e43349c6797a7b5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>