Omer Frenkel has submitted this change and it was merged. Change subject: engine: Phase 1: Move console options to backend ...................................................................... engine: Phase 1: Move console options to backend This is the 1st step for generating .vv files on backend. The patch extracts the ConsoleOptions class to backend. Changes: - Add ConsoleOptions class. It contains settings for both SPICE and VNC protocols (Instead of storing/duplicating them in AbstractSpice / AbstractVnc). - Delegating console settings in AbstractSpice and AbstractVnc to ConsoleOptions class (in the next follow up, console clients will use ConsoleOptions directly). - Extracted ticket validity timeout to constant as this parameter is not changing. This eliminates some spaghetti code. When we need variable timeout, this can be easily changed. - Same goes for secure attention mapping hotkey (aka "remap ctrl-alt-del" to "ctrl-alt-end"). It's not configurable so far so there is no need to maintain the code which does nothing. - unified common options between VNC and SPICE (like host, port, title etc.). Change-Id: Ib06110fd2b36f96f1baa55b6176240cd27a2cbf9 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com&gt; Bug-Url: https://bugzilla.redhat.com/1128763 --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleOptions.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WANDisableEffects.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WanColorDepth.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 17 files changed, 553 insertions(+), 245 deletions(-) Approvals: Frank Kobzik: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/37972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib06110fd2b36f96f1baa55b6176240cd27a2cbf9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com&gt; Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server