Arik Hadas has submitted this change and it was merged.
Change subject: core: refactor luns-monitoring
......................................................................
core: refactor luns-monitoring
1. change the visibility of some methods to package-protected
so it would be possible to mock them.
2. extract the code that fetches the luns connected to a VM
to a separate method so it could be mocked and use stream
API there.
Change-Id: I72fa6d517bc12d288760068d37a5bdfb75cbbc72
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/LunDisksMonitoring.java
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit
https://gerrit.ovirt.org/54295
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72fa6d517bc12d288760068d37a5bdfb75cbbc72
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>