Arik Hadas has submitted this change and it was merged. Change subject: core: introduce DiskContentType ...................................................................... core: introduce DiskContentType Generalize the ovf-store into a content-type of disk. Ovf-store is just one example for a case where decisions are taken according to the type of the content that is stored inside a disk. Another example would be memory dump. So this patch replaces the ovf-store specific fields with an enum that reflects the type of the content inside a disk. Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748 Signed-off-by: Arik Hadas <ahadas(a)redhat.com&gt; --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Disk.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/DiskContentType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 7 files changed, 29 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, but someone else must approve Arik Hadas: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/39143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I410a346cf0be32a99e10e503c26eb29b3688e748 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com&gt; Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt; Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com&gt; Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com&gt; Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com&gt; Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org