Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed buggy validation of NeutronAgentModel ...................................................................... webadmin: Fixed buggy validation of NeutronAgentModel Half the fields were disregarded even if they weren't valid, and the host validation was actually too harsh (but since its result wasn't regarded, it didn't block creation of providers). Change-Id: Ia6f258fb7a95a9de4b5bd2d4b71c2f8327bb1dcc Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/NeutronAgentModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/HostAddressValidation.java 2 files changed, 10 insertions(+), 6 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6f258fb7a95a9de4b5bd2d4b71c2f8327bb1dcc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server