Itamar Heim has submitted this change and it was merged. Change subject: 5. core: Supporting custom message to appear in case of expired password ...................................................................... 5. core: Supporting custom message to appear in case of expired password The bug description stays that in case of failed login, the user may get a URL to change the passord, or a custom message. In order to support that, the following changes were introduced: a. manage-domains code -changePasswordUrl was changed to -changePasswordMsg. b. The input is done in interactive mode. c. The read value is encoded (as may contain characters like space, : and ,) d. The manage-domains script was changed accordingly e. The vdc_options relevant entry was changed (so was the ConfigValues relevant enum literal). f. ProsivinalAuthenticationResult reads the entry from the configuration and decodes it. g. A proper VDC BLL message is used depending on whether the content is URL or not (a new VdcBllMessage was introduced). Bug-Url: https://bugzilla.redhat.com/1053601 Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticationResult.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M packaging/bin/engine-manage-domains.sh M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 9 files changed, 92 insertions(+), 55 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f656f38f7f48e169ed01ad084d7f424e5c749f3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server