Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Improve column control menu ...................................................................... webadmin: Improve column control menu 1. replaced JavaScript/jQuery JSNI code with proper Java/GWT code to avoid performance issues & leaks 2. replaced up/down arrow icons on menu items with drag'n'drop Side note: HTML5 DnD spec is a _total_ mess. Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Bug-Url: https://bugzilla.redhat.com/1285499 Bug-Url: https://bugzilla.redhat.com/1368101 Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnController.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ColumnContextMenu.css D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_no.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_yes.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_down.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_up.png 11 files changed, 328 insertions(+), 375 deletions(-) Approvals: Alexander Wels: Verified; Looks good to me, approved; Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/54186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>