Tal Nisan has submitted this change and it was merged. Change subject: core: add MockConfigDescriptor for StoragePoolNameSizeLimit ...................................................................... core: add MockConfigDescriptor for StoragePoolNameSizeLimit The method StorageHandlingCommandBase.getStoragePoolNameSizeLimit() returns a config value. This patch removes the mocking of getStoragePoolNameSizeLimit(), and instead adds a new config descriptor to the existing config rule. Since only StorageHandlingCommandBase used this method at only one place, it has been inlined. Change-Id: I8b54e51033abe03889d617fe4217fd9611d80499 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java 2 files changed, 3 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/49350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b54e51033abe03889d617fe4217fd9611d80499 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>