Alona Kaplan has submitted this change and it was merged. Change subject: engine: Re-define HostSetupNetworks based on network attachments ...................................................................... engine: Re-define HostSetupNetworks based on network attachments The same old api is being redefined by network attachment and by externalizing the business logic out from the VDS command into the producer of the parameters (will be introduced in a latter patch). Change-Id: I75d02e4be71f00510bc8815c555a94d7efc9252e Signed-off-by: Moti Asayag <masayag(a)redhat.com&gt; Signed-off-by: Martin Mucha <mmucha(a)redhat.com&gt; --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FutureVDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostSetupNetworksVdsCommandParameters.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java 4 files changed, 382 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Verified Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/32910 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75d02e4be71f00510bc8815c555a94d7efc9252e Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com&gt; Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com&gt; Gerrit-Reviewer: automation(a)ovirt.org