Daniel Erez has submitted this change and it was merged. Change subject: webadmin: upload image - validate image selection ...................................................................... webadmin: upload image - validate image selection On 'Image Upload' dialog, when no file is selected, there's no validation and indication upon pressing the OK button. Hence, added a proper validation and an error message when no file is selected. Change-Id: I7e30411b6c2dfd052f93f479318d3090ca1981ee Bug-Url: https://bugzilla.redhat.com/1358727 Signed-off-by: Daniel Erez <derez@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java 4 files changed, 25 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Daniel Erez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e30411b6c2dfd052f93f479318d3090ca1981ee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>