From Tal Nisan <tnisan@redhat.com>:

Tal Nisan has submitted this change and it was merged. Change subject: core: add vm exit reason of type unknown ...................................................................... core: add vm exit reason of type unknown When restoring a backup, the status and run_on_vds fields of the VM do not represent the actual information of the running VM. This may lead of unneeded restart of highly-available VMs that would cause a split-brain. Therefore, we decide to switch highly-available VMs to down when restoring a backup. But none of the existing exit reasons fit for this flow: Error would cause the VM to be restarted when the engine starts, and Normal doesn't reflect the situation properly since the VM was not shut-down properly. Thus, we add a new exit reason for this case, called Unknown. The whole purpose of this value, for now, is to prevent the automatic VM restart mechanism to skip VMs set with this value. Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Bug-Url: https://bugzilla.redhat.com/1441322 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmExitStatus.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/75904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40710a943c60dbdbbdf9e8e9563afc121d1d632a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>