Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: queryEnvKey db creds, rely on hostname fixes ...................................................................... packaging: setup: queryEnvKey db creds, rely on hostname fixes Changed the code querying for database credentials to use queryEnvKey. Rely on hostname fixes in ovirt-setup-lib to test for dns resolution only for the engine in all-in-one instead of always in all-in-one (including e.g. remote db). Also made that caller-configurable instead of env. Depends-On: https://gerrit.ovirt.org/#/c/43856/ Change-Id: I8ad3d19d73b41c608ee8ca806591a29b7a8216d6 Signed-off-by: Yedidyah Bar David <didi@redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/util.py 2 files changed, 87 insertions(+), 96 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ad3d19d73b41c608ee8ca806591a29b7a8216d6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>