Sandro Bonazzola has submitted this change and it was merged. Change subject: python: cleanup import lines using isort ...................................................................... python: cleanup import lines using isort Ran isort on all the python files included in the project with the following configuration. $ cat ~/.isort.cfg [settings] line_length=79 known_standard_library=configparser,Cheetah.Template force_single_line=True default_section=FIRSTPARTY known_otopi=otopi known_host_deploy=ovirt_host_deploy known_ovirt_engine=ovirt_engine known_ovirt_engine_setup=ovirt_engine_setup known_ovirt_setup_lib=ovirt_setup_lib known_vdsm=vdsm known_ovirt_hosted_engine_setup=ovirt_hosted_engine_setup sections=FUTURE,STDLIB,FIRSTPARTY,OTOPI,VDSM,HOST_DEPLOY,OVIRT_ENGINE,OVIRT_ENGINE_SETUP,OVIRT_SETUP_LIB,OVIRT_HOSTED_ENGINE_SETUP,THIRDPARTY,LOCALFOLDER lines_between_types=2 Change-Id: I43408de12eec10fd91a0fad9c6e8e510a6566ad4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; --- M build/helptag-oneline-check.py M build/helptag.py M build/helptag_checker.py M packaging/libexec/ovirt-vmconsole-proxy-helper/ovirt-vmconsole-list.py M packaging/pythonlib/ovirt_engine/java.py M packaging/pythonlib/ovirt_engine/service.py M packaging/pythonlib/ovirt_engine/ticket.py M packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py M packaging/services/ovirt-engine/ovirt-engine.py M packaging/services/ovirt-fence-kdump-listener/db.py M packaging/services/ovirt-fence-kdump-listener/listener.py M packaging/services/ovirt-fence-kdump-listener/ovirt-fence-kdump-listener.py M packaging/services/ovirt-websocket-proxy/ovirt-websocket-proxy.py M packaging/setup/ovirt_engine_setup/dockerc/constants.py M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/ovirt_engine_setup/engine/vdcoption.py M packaging/setup/ovirt_engine_setup/engine_common/database.py M packaging/setup/ovirt_engine_setup/engine_common/postgres.py M packaging/setup/ovirt_engine_setup/firewall_manager_base.py M packaging/setup/ovirt_engine_setup/remote_engine.py M packaging/setup/ovirt_engine_setup/remote_engine_base.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py M packaging/setup/ovirt_engine_setup/websocket_proxy/constants.py M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py M packaging/setup/plugins/ovirt-engine-common/base/core/misc.py M packaging/setup/plugins/ovirt-engine-common/base/core/offlinepackager.py M packaging/setup/plugins/ovirt-engine-common/base/core/postinstall.py M packaging/setup/plugins/ovirt-engine-common/base/core/reconfigure.py M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py M packaging/setup/plugins/ovirt-engine-common/base/dialog/titles.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_firewalld.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_human.py M packaging/setup/plugins/ovirt-engine-common/base/network/firewall_manager_iptables.py M packaging/setup/plugins/ovirt-engine-common/base/network/hostname.py M packaging/setup/plugins/ovirt-engine-common/base/network/process_firewalld_services.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_manual_files.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py M packaging/setup/plugins/ovirt-engine-common/base/system/hostile_services.py M packaging/setup/plugins/ovirt-engine-common/base/system/mem.py M packaging/setup/plugins/ovirt-engine-common/base/system/selinux.py M packaging/setup/plugins/ovirt-engine-common/dockerc/core.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/config/java.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/protocols.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/apache.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/environment.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/he.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/engine.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/config.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/pgpass.py M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/core.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/offlinepackager.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/database.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-remove/base/core/misc.py M packaging/setup/plugins/ovirt-engine-remove/base/files/simple.py M packaging/setup/plugins/ovirt-engine-remove/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-remove/dockerc/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/misc.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/clear.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/engine.py M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/fence_kdump_listener.py M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/engine.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/misc.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/protocols.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/sso.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/tools.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/uninstall.py M packaging/setup/plugins/ovirt-engine-rename/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/base/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/base/dialog/preview.py M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py M packaging/setup/plugins/ovirt-engine-setup/base/system/environment.py M packaging/setup/plugins/ovirt-engine-setup/dockerc/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/core.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/selinux.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/ssl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/titles.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/root.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaainternal.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaajdbc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaakerbldap.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/appmode.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/domain_type.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/dwh_database.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/firewall.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/java.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/jboss.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/notifier.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/options.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/protocols.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/storage.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/tools.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/config.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ssh.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/postgres.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/engine.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/image_upload.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/answerfile_fixup.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dwh.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/pki.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/system.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/config.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/packages.py M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/pki.py 143 files changed, 436 insertions(+), 197 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43408de12eec10fd91a0fad9c6e8e510a6566ad4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com&gt; Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com&gt; Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com&gt; Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com&gt; Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com&gt; Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com&gt; Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;