From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: Remove disk confirmation doesn't fail
......................................................................
userportal: Remove disk confirmation doesn't fail
Problem: Edit VM dialog threw ClassCastException when "-" button was
clicked to remove VM disk in userportal extended. The problem was that
there weren't registered special confirmation model popup provider and
the default confirmation view (DefaultConfirmationPopupView) expects to
work with String-s but DiskModel instance was provided in
RemoveDiskModel#initialize().
Solution: Copied from webadmin: From now on the confirmation dialog is
handled by VmDiskRemovePopupPresenterWidget the view of which can work
work with DiskModel instances.
Change-Id: Ic735419f4465bc1ac85b8be7b87962b5a68d3dd1
Bug-Url:
https://bugzilla.redhat.com/1414455
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/71283
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic735419f4465bc1ac85b8be7b87962b5a68d3dd1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>