From Allon Mureinik <amureini@redhat.com>:

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Compact annotation style ...................................................................... engine: Compact annotation style Remove redundant array declaration from compact annotation definitions, and add a checkstyle check to ensure this style is preserved. Change-Id: Ia0551fb98b7588cdb529bbc73c87082e82da6b36 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Cidr.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/MTU.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Mask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/SizeFromConfigValue.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidCluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNetworkConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidTimeZone.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/Actionable.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/Mapping.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Logged.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/VmPopupResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderSecretPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java 21 files changed, 22 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0551fb98b7588cdb529bbc73c87082e82da6b36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Betak <mbetak@redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>