Change in ovirt-engine[master]: core: Two @Before methods in RunVmCommandTest merged

Arik Hadas has submitted this change and it was merged. Change subject: core: Two @Before methods in RunVmCommandTest merged ...................................................................... core: Two @Before methods in RunVmCommandTest merged It is generally bad practise to have multiple @Before methods because there is no order defined in which they are called. In this case createCommand() method expected to be called after initMockitoAnnotations() method. Change-Id: Ifdae8675cab236b4c10b3cb4f064ad9af70a0ac2 Signed-off-by: Jakub Niedermertl <jniederm@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdae8675cab236b4c10b3cb4f064ad9af70a0ac2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>
participants (1)
-
ahadas@redhat.com