Tal Nisan has submitted this change and it was merged.
Change subject: engine: NPE in GLUSTERFSStorageHelper
......................................................................
engine: NPE in GLUSTERFSStorageHelper
Fixing the ConnectHostToStoragePoolServersParameters constructor,
to include 'StoragePool'.
In the flow of refreshing storage connections and pool metada due to
Vdsm reports, the ConnectHostToStoragePoolServersParameters constructor
was used without 'StoragePool'.
Several classes like CINDERStorageHelper and GLUSTERFSStorageHelper are
expecting the parameter to have a StoragePool populated.
Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138
Bug-Url:
https://bugzilla.redhat.com/1277570
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ConnectHostToStoragePoolServersParameters.java
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Amit Aviram: Looks good to me, but someone else must approve
Freddy Rolland: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/48258
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b80bcc9606677912e88dc265d36c8c9f8ba8138
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org