Eli Mesika has submitted this change and it was merged. Change subject: tools: notifier: more changes in NotificationProperties ...................................................................... tools: notifier: more changes in NotificationProperties split validate into sub calls (validateBasic, validateEmail ...) to sections. as more sections are expected in following commits (validateFilter, validateSnmp ). Order methods (constructor befor any other method). Apply code style & add requireAll and requireOne methods. Change-Id: I2ebbf76a23c79d354cb9026dc3ad0f4310a804be Signed-off-by: Mooli Tayer <mtayer(a)redhat.com&gt; --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java 1 file changed, 141 insertions(+), 89 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ebbf76a23c79d354cb9026dc3ad0f4310a804be Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com&gt; Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com&gt; Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com&gt; Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com&gt; Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt; Gerrit-Reviewer: oVirt Jenkins CI Server