Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add validation for not null cpu ...................................................................... core: Add validation for not null cpu Not null cpu (for virt service upon adding a new Cluster) should be added. Current behavior (prior to this patch) will produce a canDoAction of "cpu is not supported" but this is a wrong message in case of null cpu (this message should be kept for a non null cpu which indeed is not supported for a given compatbility version) Change-Id: I7f6433390ad85e9ba7431b206d15a5f8d6846736 Acked-by: Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VdsGroupValidator.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidVdsGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 61 insertions(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/5399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f6433390ad85e9ba7431b206d15a5f8d6846736 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>