Tal Nisan has submitted this change and it was merged. Change subject: engine: old SetupNetworks, NPE when attaching network to host NIC ...................................................................... engine: old SetupNetworks, NPE when attaching network to host NIC NPE in the follwing cases- 1. Just the name of the attached network is passed (not the id). 2. Just the name of the nic is passed. 3. The 'vdsId' is not set on the passed host nic. Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Bug-Url: https://bugzilla.redhat.com/1260430 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 3 files changed, 51 insertions(+), 17 deletions(-) Approvals: Alona Kaplan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1242f13a34df4bbdd7eee1e094cc02f28105585d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org