Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replacing search for vms by query ...................................................................... engine: Replacing search for vms by query The following patch will replace the search for VMs which belong to some cluster, by query from DB. The query is much more efficient than search , and easy to understand. The patch contains: 1. Introducing new query 2. Replace all searches by new query 3. Removed class HighAvailableVmsDirector (The following class also uses a search query, but the class is not used anywhere, that's why I remove it instead of replacing search query) Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1 Signed-off-by: Michael Kublin <mkublin@redhat.com> --- M backend/manager/dbscripts/vms_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HighAvailableVmsDirector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceVdsBaseCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java 12 files changed, 84 insertions(+), 171 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Michael Kublin: Verified -- To view, visit http://gerrit.ovirt.org/11426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12cee2c66aed35ed357f2ee739232d95fe9fa0c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>