Sandro Bonazzola has submitted this change and it was merged. Change subject: network: fixing hostname - interface enforcing for DHCP setups ...................................................................... network: fixing hostname - interface enforcing for DHCP setups https://gerrit.ovirt.org/#/c/53142/ is enforcing that the hostname resolves on the interface where we are going to create the bridge on. Vds_info.network on the other side wasn't returning an ip addr if the interface was configured for DHCP so this enforcing was always failing if the user rely on DHCP. Fixing it. Simply using socket.getfqdn() on additional hosts. Change-Id: Ie09301e6142c8bc6b009b02ae252bcac78b2f063 Bug-Url: https://bugzilla.redhat.com/1308333 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --- M src/ovirt_hosted_engine_setup/vds_info.py M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 2 files changed, 60 insertions(+), 27 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie09301e6142c8bc6b009b02ae252bcac78b2f063 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken@redhat.com> Gerrit-Reviewer: Edward Haas <edwardh@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>