Maor Lipchuk has submitted this change and it was merged. Change subject: core: Validate steps using CoCo on RunVmCommand ...................................................................... core: Validate steps using CoCo on RunVmCommand When RunVmCommand calls CreateAllsnapshotsFromVmCommand with execution context it should use getContext instead of cloneContext so the executionContext of RunVmcommand should also get updated with the relevant steps. The reason why this should be changed is because CoCo is using the executionContext of the command itself while the AsyncTaskManager sets the executionContext of the child, CreateAllsnapshotsFromVmCommand, once RunVmCommand is being called. Once the engine also sets the context of the existing command, RunVmCommand, the engine will not throw an NPE that the step does not exists. Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6 Bug-Url: https://bugzilla.redhat.com/1305809 Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>