Alona Kaplan has submitted this change and it was merged. Change subject: engine: Fix unit tests that were broken by multiple gateways ...................................................................... engine: Fix unit tests that were broken by multiple gateways Multiple gateways feature broke two unit test. Commit 663243e46549d3796fd50fa362520e0e20cf45b5 fixed the broken tests. This patch adds some improvements to the fixes were done. 1. In SetupNetworkHelper gateway validation now checks the ConfigValues.MultipleGatewaysSupported- a mock was added to fix the test. 2. Gateway validation was removed from NetworkInterfaceValidator- fix the test to emphasisthere are case we support gateway for non management network. Change-Id: I1d453ea1efe736dd16dea9b793d784bee4225af8 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 2 files changed, 29 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d453ea1efe736dd16dea9b793d784bee4225af8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server