Roy Golan has submitted this change and it was merged. Change subject: core: skip quota for flows with no storage pool ...................................................................... core: skip quota for flows with no storage pool Quota checks are being made based on a commands "quota dependency" which is being marked by an enum on the VdcActionType. The problem is that some commands, e.g. AddDisk may need quota check on regular disk but not on external floating LUN disk, mainly because this command will not have a storage pool (floating disk doesn't belong to a data center) thus - no quota could be calculated on it. As a way out, instead of breaking a command to two, (one quotable and one not) an empty list of quota params can be submitted so no quota checks will be made. Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Signed-off-by: Roy Golan <rgolan(a)redhat.com&gt; --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java 2 files changed, 15 insertions(+), 7 deletions(-) Approvals: ofri masad: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt; Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt; Gerrit-Reviewer: ofri masad <omasad(a)redhat.com&gt;