From Allon Mureinik <amureini@redhat.com>:

Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79480 ) Change subject: backend: don't remove VG ID of direct lun that is a part of a SD ...................................................................... backend: don't remove VG ID of direct lun that is a part of a SD When synchronizing a direct lun, the VG ID that comes from getDeviceList used to be changed to an empty string before updating the lun in the DB, assuming that a direct lun doesn't have a VG ID and thus the information that comes from vdsm is old and irrelevant. That isn't true when talking about a lun which is a part of a storage domain (and thus has a VG ID) and is also used as a direct lun. Therefore, this patch makes sure that when synchronizing a direct lun, the VG ID will be updated only if it is not an empty string. Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49 Bug-Url: https://bugzilla.redhat.com/1471759 Signed-off-by: Idan Shaby <ishaby@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommandTest.java 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/79480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>