Piotr Kliczewski has submitted this change and it was merged.
Change subject: engine: add integer to IPv4 format converter
......................................................................
engine: add integer to IPv4 format converter
The functionality needed to be implemented as GWT
doesn't support INetAddress
Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa
Bug-Url:
https://bugzilla.redhat.com/1269481
Signed-off-by: Eliraz Levi <elevi(a)redhat.com>
---
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPAddressConverter.java
A
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IPv4AddressConverter.java
D
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IpAddressConverter.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/CidrValidator.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/MaskValidator.java
A
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPv4AddressConverterTest.java
D
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IpAddressConverterTest.java
M
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
8 files changed, 139 insertions(+), 82 deletions(-)
Approvals:
Piotr Kliczewski: Passed CI tests
Eliraz Levi: Verified
Alona Kaplan: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/49921
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57fb8105cbc5208ecac0652f0c2f7e678fe01ffa
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>