Roy Golan has submitted this change and it was merged. Change subject: core: extract unmanaged hosted engine code from vms monitoring ...................................................................... core: extract unmanaged hosted engine code from vms monitoring Extract the code that handles installed hosted-engine VM from VmsMonitoring to simplify VmsMonitoring and reduce duplicated code with AddUnmanagedVmsCommand. The analyzer treats installed hosted-engine VM as an external VMs and pass it to the AddUnamangedVmsCommand. The command in turn identifies installed hosted- engine VM as external hosted-engine VM that should be imported. A positive side-effect of this change, besides the ones mentioned above, is that we now store the static part of the VM before flushing the refreshed data to the database and therefore at the end of the first cycle in which we get the VM we will have the VM presented with the right status. Change-Id: Ie19247de8093bd79e8bb3ae62233d79853bbb601 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 4 files changed, 26 insertions(+), 65 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie19247de8093bd79e8bb3ae62233d79853bbb601 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>