Allon Mureinik has submitted this change and it was merged. Change subject: core: Consolidate Guid.createFromStringXXX impl ...................................................................... core: Consolidate Guid.createFromStringXXX impl Consolidated the implementation of Guid.createFromString(Stirng) and Guid.createFromStringDefaultEmpty(String), and added some unit tests to assure no functionality was broken. Change-Id: I91521dd873c6c9a3594ea601d79954e8915d1a00 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/GuidTest.java 2 files changed, 25 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91521dd873c6c9a3594ea601d79954e8915d1a00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Liron Ar <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server