From Vojtech Szocs <vszocs@redhat.com>:

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Cleanup POMs ...................................................................... frontend: Cleanup POMs - frontend modules containing Java code subject to GWT compilation now have (at least) two build artifacts: * {artifactId}-{version}.jar - .class files - resource files, e.g. *.gwt.xml * {artifactId}-{version}-sources.jar - .java files - to ensure that GWT compiler sees Java sources *AND* to ensure that GWT debugger is able to detect changes in those sources, WebAdmin & UserPortal POMs now have: <dependency> <groupId>${engine.groupId}</groupId> <artifactId>MODULE_NAME</artifactId> <version>${engine.version}</version> <scope>provided</scope> </dependency> <dependency> <groupId>${engine.groupId}</groupId> <artifactId>MODULE_NAME</artifactId> <version>${engine.version}</version> <classifier>sources</classifier> <scope>provided</scope> </dependency> for each frontend module containing GWT/Java code, which means we don't treat Java sources as resources from Maven perspective. For details, see [1][2]. [1] http://stackoverflow.com/a/27470661 [2] https://gwt-maven-plugin.github.io/gwt-maven-plugin/ compile-mojo.html#compileSourcesArtifacts - above also implies that any JARs to be deployed onto Engine server (WildFly) are *WITHOUT* Java sources: * frontend.jar # oVirt specific * gwt-extension.jar # oVirt specific * gwt-servlet.jar # 3rd party (GWT RPC runtime) Change-Id: I862d2e04dc14fcecccf9408c14415c78b3e7e93a Signed-off-by: Vojtech Szocs <vszocs@redhat.com> --- M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 7 files changed, 143 insertions(+), 42 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/74187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862d2e04dc14fcecccf9408c14415c78b3e7e93a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Alexander Wels <awels@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>