Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] introduce GetAllFromExportDomainQuery class ...................................................................... core: [cleanup] introduce GetAllFromExportDomainQuery class This patch changes hierarchy which is logically wrong and reduces the amount of code duplication: Before this patch GetTemplatesFromExportDomainQuery inherited GetVmsFromExportDomainQuery which is wrong since there's no kind-of relationship between those classes, and there was duplicated code between those two classes. GetAllFromExportDomainQuery is added as a parent for the above classes - they both are kind-of query that returns all from export domain thus the relations are logically ok, and the new class contains code which is join for both classes. This hierarchy will make it easier to add query for instance-types from export domain later. Change-Id: I2544cb879898ef90d64feb8a16dcfb8cf103b409 Signed-off-by: Arik Hadas <ahadas@redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllFromExportDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java 3 files changed, 132 insertions(+), 129 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2544cb879898ef90d64feb8a16dcfb8cf103b409 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com>