Alona Kaplan has submitted this change and it was merged. Change subject: engine: Adjust NetworkUtils to accept any vlan device name- phase 1 ...................................................................... engine: Adjust NetworkUtils to accept any vlan device name- phase 1 The changes in this class will be done in two phases. Phase 1 (in this patch)- Adjusting NetworkUtils to get the underling interface name of the nic by using VdsNetworkInterface.getBaseInterface() instead of determine the underling nicName from the vlan device name. In this patch old methods signatures are NOT changed in order to avoid breaking the compilation. If a change to the signature is needed, a new method overloads the old one is added. Phase 2- Removing the old methods. Will be done after all the usages of the old methods are replaced/fixed. Change-Id: I426159c169b1fa478776abafb38cb7ae6fdac3be Bug-Url: https://bugzilla.redhat.com/1091863 Bug-Url: https://bugzilla.redhat.com/999975 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 2 files changed, 35 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Alona Kaplan: Verified -- To view, visit http://gerrit.ovirt.org/26608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I426159c169b1fa478776abafb38cb7ae6fdac3be Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server