Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Support "basestring" in Python 3 ...................................................................... sdk: Support "basestring" in Python 3 The code generated by the "generateDS.py" tool uses the "basestring" builtin. This has been removed in Python 3. In order to support both Pyton 2 and Python 3 this patch creates "basestring" as follows: try: basestring = basestring except NameError: basestring = str Change-Id: Ic8f357aafb361e2c5d5d314260222571720def73 Related: https://bugzilla.redhat.com/1096137 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/XsdCodegen.java A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/BasestringHackTemplate A generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/BasestringHackTemplate.java M src/ovirtsdk/xml/params.py 4 files changed, 65 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me; Ready for merge; Passed CI tests -- To view, visit https://gerrit.ovirt.org/41333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8f357aafb361e2c5d5d314260222571720def73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ravi Nori <rnori@redhat.com> Gerrit-Reviewer: automation@ovirt.org