Allon Mureinik has submitted this change and it was merged. Change subject: core: Distinguish duplicates props from IO errors ...................................................................... core: Distinguish duplicates props from IO errors This patch enhances the DuplicateKeysCheck so it may distinguish between errors loading a properties file (which should be an error) and duplicate properties within those properties (which should be a test failure). Change-Id: I9baeed9d528e07e4256ef8bc2221f7522405285b Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicateKeysCheck.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicatePropertyException.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java M frontend/webadmin/modules/userportal-gwtp/src/test/java/org/ovirt/engine/ui/userportal/DuplicateKeysTest.java M frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java 6 files changed, 17 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/43917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9baeed9d528e07e4256ef8bc2221f7522405285b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org